On 23.12.2017 16:27, Troy Curtis Jr wrote: > > On Fri, Dec 22, 2017 at 11:11 PM Daniel Shahaf <d...@daniel.shahaf.name > <mailto:d...@daniel.shahaf.name>> wrote: > > While reviewing this I also noticed that svn_swig_py_convert_ptr() > also > does this hasattr() check — not sure whether it needs to change too? — > and also has an "x | 0" construct, which seems suspicious (isn't it a > no-op?). > > > I looked back through the logs in an attempt figure out the rationale > for the "x | 0" construct, but it just shows up that way when it was > first added [0]. I agree, it should just be changed to the define. I > can't come up with a reason to 'or' with 0.
It's not necessarily a no-op: depends on the type of 'x', if it's smaller than an int, then 'x | 0' involves an implicit type conversion. -- Brane
