On 16.01.2018 03:42, Nathan Hartman wrote: >> On Jan 15, 2018, at 11:42 AM, Julian Foad <julianf...@apache.org> wrote: >> >> About this new-for-1.10 API: >> [[[ >> /** Reads a string from stdin until a newline or EOF is found >> * >> * @since New in 1.10. >> */ >> svn_error_t * >> svn_io_stdin_readline(const char **result, >> apr_pool_t *result_pool, >> apr_pool_t *scratch_pool); >> ]]] >> >> Compare with svn_stream_readline() and svn_io_file_readline(): >> * they read into a svn_stringbuf_t; >> * they have EOL and EOF params; >> * svn_io_file_readline() has max_len param; >> >> It seems to me it would be better to make this new function more similar to >> them. >> >> Thoughts? >> >> - Julian > I didn't look at the context but it looks like, at a bare minimum, this > function needs a size of result param to avoid overrunning a buffer.
No, that's not a problem because the function allocates the buffer and returns a pointer to it. -- Brane
