On Sun, Feb 11, 2018 at 4:33 PM Daniel Shahaf <d...@daniel.shahaf.name> wrote:
> Troy Curtis Jr wrote on Sun, 11 Feb 2018 16:10 +0000: > > I'm asking for comments because the actual diff output given when > > 'diffoptions' is None, is changed. > ... > > Thoughts? > > 1. We have two consumers of FileDiff in tools/. Check whether they are > affected? > > tools/examples/svnlook.py calls with diffoptions, so it is unaffected as using args will call the executable (since that is obviously the desire having given arguments). tools/hook-scripts/mailer/mailer.py's output would be changed. There are also other headers output on various conditions that mailer.py detects, like adding and removing files. The more I look at it the more I think that perhaps the backwards compatible change of defaulting diff options to '[]' and checking specifically for 'None' to use the internal tool would be the way to go. That way you can actually get to the internal subversion diff implementation if you want, but the default behavior doesn't change. Troy > 2. We might include the change in an alpha/beta release to give it more > testing. > > (#2 applies to FSFS's new verify-before-commit knob, too.) > > Cheers, > > Daniel >
