Dmitry, the other thing is, would you mind making a regression test for this issue? That would be really good to have.
- Julian Julian Foad wrote on 2018-07-09: > Dmitry Pavlenko wrote on 2018-07-09: > > Note that the patch looks like > > > > Index: /tmp/wc > > =================================================================== > > diff --git a/ b/ > > --- a/ (revision 0) > > +++ b/ (working copy) > > > > Property changes on: > > [...] > > Thanks for the bug report. I like removing code. Before we commit this, > I have a few questions (for anybody who can answer) about how this > should be working. > > I think the "Property changes on: " line is not right: it should show a > dot for the path: "Property changes on: ." > > Maybe the "diff --git" line should say "diff --git a/. b/." for > consistency (other directory paths printed there do not end with a > slash) and clarity. (Would that even make the "svn patch" operation work > correctly?) > > We could do both fixes: make "svn diff" add a dot, to be more > conservative; and also make "svn patch" not require a dot, to be more > lenient, and to work with already-generated patches. > > - Julian -- - Julian
