Branko Čibej wrote on Wed, 26 Dec 2018 23:28 +0100: > On 26.12.2018 22:41, Branko Čibej wrote: > > On 26.12.2018 19:50, Daniel Shahaf wrote: > >> br...@apache.org wrote on Wed, 26 Dec 2018 04:28 +0000: > >>> + * - apache::subversion::svnxx::canceled\n > >>> + * Thrown when an operation was canceled > >>> + * + apache::subversion::svnxx::cancel\n > >>> + * Thrown by user callbacks to terminate iteration > >> I think the last two names here are too similar; it'll be way too easy > >> to mis-tab-complete them for each other. Suggest to rename the second > >> one to stop_iteration to match the name of SVN_ERR_STOP_ITERATION. > > Actually users can't create objects of type 'svn::canceled' — or at > > least not without a lot of effort, as there are no public constructors. > > I would hope a smart IDE would notice, or else at least a smart user > > will. :) > > > > But yes, I hear you. stop_iteration is a good suggestion. > > > Out of interest ... where is SVN_ERR_STOP_ITERATION defined? I can't > find it on trunk.
Sorry, SVN_ERR_ITER_BREAK. StopIteration is a Python exception class. Cheers, Daniel
