On Fri, Aug 2, 2019 at 12:53 PM <danie...@apache.org> wrote: >... > +++ subversion/site/tools/upcoming.py Fri Aug 2 17:53:38 2019 > >...
> +def get_reference_version(): > + "Return the version to use as the oldest end of the 'svn log' output > to generate." > + def _is_working_copy(): > + return os.path.exists('subversion/include/svn_version.h') > + if _is_working_copy(): > Why a local func instead of just using os.path.exists() in the 'if' statement? If for doc purposes, then I think a comment would suffice. Cheers, -g