On Thu, Nov 14, 2019 at 1:51 PM Daniel Shahaf <[email protected]> wrote:
> Nathan Hartman wrote on Thu, 14 Nov 2019 18:14 +00:00: > > On Thu, Nov 14, 2019 at 10:33 AM Daniel Shahaf <[email protected]> > wrote: > > > [email protected] wrote on Thu, 14 Nov 2019 05:26 +00:00: > > Isn't it more accurate that building from tarball doesn't require > > Python but building from a working copy (whether from branches/tags or > > trunk) does? > > Well, yes, but the release notes aren't aimed at people building trunk. > Also, "tag of 1.13.0" v. "tarball of 1.13.0" is a minimal pair; > "trunk@HEAD" v. "tarball of 1.13.0" is not. Good point. > Thoughts? > > The content looks good. > > Suggest to move the mention of test suite to the second paragraph, since > it only affects downstream maintainers, not downstream users. Agreed. Suggest to delete the "Note ...:" clause, to improve flow. Instead, perhaps > "If you build Subversion yourself, Python is required if you build from a > checked > out working copy or run the test suite, but not otherwise"? Too many "if's" in one sentence but I agree that the note text needs to be restructured for better clarity and to separate between issues of concern for end users / server operators and those which concern maintainers and packagers. Not directly related, but the phrase "other Python-coded tools" makes > for a circular definition. Does svnlook qualify? (You and I know it > doesn't, but that's an implementation detail.) Maybe make those words a > link to .../branches/1.13.x/tools/? That could include 3rd party tools (though I did write "that ship with Subversion"). Unfortunately I can't seem to think of another way to say it besides "other Python-coded tools." Here's the next attempt... [[[ Python is optional. Subversion does not require Python for its basic operation. In general, if you are not using Subversion's SWIG Python bindings, hook scripts coded in Python, or other tools that require Python, then this change does not affect you. You may need Python if you are building Subversion from source. Python is not strictly required when building from a distribution tarball, but is required to: * build from a source checkout * run Subversion's automated test suite * run other maintainer-oriented scripts ]]] Cheers, Nathan
