Daniel Shahaf wrote:
julianf...@apache.org wrote on Mon, 18 Nov 2019 16:31 +00:00:
Author: julianfoad
Date: Mon Nov 18 16:31:45 2019
New Revision: 1869981
URL: http://svn.apache.org/viewvc?rev=1869981&view=rev
Log:
* tools/dist/release.py (recommended_release): Remove TODO: didn't make sense.
The point of that TODO is that instead of hardcoding
«recommended_release» in the source code, we can derive it from the version
number being
rolled and the version numbers currently available for download. This way, we
won't have to
manually update «recommended_release» as part of the release process.
The version being rolled is any version we want to roll, probably but
not necessarily a supported version (it's not forbidden to use this tool
to roll an unsupported version), and certainly not necessarily the
currently recommended version.
The set of versions currently available for download is one of the
outputs that we are possibly intending to change during the release
process (depending on what sort of release it is, or maybe it's a test
roll and not a release at all). One of the things release.py does is
help us generate the 'downloads' page.
The definition of what is the currently "recommended" release is an
input to the "release.py" part of the release management process.
What am I missing?
- Julian
+++ subversion/trunk/tools/dist/release.py Mon Nov 18 16:31:45 2019
@@ -102,7 +102,6 @@ tool_versions['1.13'] = tool_versions['1
# The version that is our current recommended release
-# ### TODO: derive this from svn_version.h; see ../../build/getversion.py
recommended_release = '1.13'
# For clean-dist, a whitelist of artifacts to keep, by version.
supported_release_lines = frozenset({"1.9", "1.10", "1.13"})
