On 2019/12/13 19:47, Daniel Shahaf wrote: > Yasuhito FUTATSUKI wrote on Fri, Dec 13, 2019 at 17:28:18 +0900: >> Thank you for testing. I also tested and same result on FreeBSD >> with Python 3.6. It seems "z*" format in PyArg_ParseTuple() doesn't >> work I expected. >> >> On the other hand, I can't find good reason to care typemap for >> "const char *config_dir" input different from other MAY_BE_NULL types >> on Python bindings only, so I removed this special handling. >> Then, it works :) > > I don't see any reason either, and I confirm this version of the patch fixes > both issues. Thanks again for the quick fix.
It seems this extra typemap have been forgotten to remove when MAY_BE_NULL was introduced. I'll commit this patch after testing on Python 2.7. > I forgot to say this earlier, but I ran into some problems trying to apply > your > patch. The indentation was corrupted: the line that start with spaces, above, > had an extra leading space. To cut a long story short, your email was > formatted > with format=flowed, which means two things: > > - Your MUA correctly space-stuffed the unidiff context lines, but on my end, > Mutt did not un-space-stuff them before piping them to patch(1). Therefore, > patch(1) saw one leading space too many on the context lines, and > (correctly) > failed. > > - In general, format=flowed and inline patches don't mix — IIRC, the problem > is > that unidiffs that contain lines with trailing spaces will be corrupted — so > you should either disable format=flowed on your end or send patches as > attachments (as opposed to inline). See: > https://wiki.openstack.org/wiki/MailingListEtiquette#Thunderbird Thank you for this informaiton. I've changed my Thunderbird setting (at least this one, and I'll do it on other environments). Cheers, -- Yasuhito FUTATSUKI <futat...@poem.co.jp>
