On Sat, Dec 14, 2019 at 6:13 AM Stefan Sperling <s...@elego.de> wrote:
> 'svn patch' already behaves like regular patch, i.e. it assumes the whole > line > denotes a file name if no TAB can be found. > > The problem is that svn diff's revision number marker " (revision XY)" must > be separated by a TAB. Otherwise it becomes part of the file name. > Perhaps --patch-compatible should omit those markers? > The real problem is historical: poorly defined headers. If the headers were simply: Something1: <stuff until end of line> Something2: <stuff until end of line> Then there would be no problem. With the current setup, the ambiguity means that some file names are explicitly disallowed from being supported due to a lack of disambiguating syntax (some type of quoting). So the two file names, differing only by a TAB in the "right place" will currently have completely different behaviors: My File NameSPACE(Revision 12) My File NameTAB(Revision 12) I see no point in maintaining that the "TAB" is critically significant and different from the "SPACE". The difference is easier parsing vs. 1 visually indistinguishable use case (depending on what tool you are using to view the diff file). And the "sequence of SPACE" instead of just a single "SPACE" falls into the same visually indistinguishable category. So keep the parsing simple and just declare file names with "SP/TAB(Revision #)" at the end to not be supported. Cheers. Doug -- *DOUGLAS B ROBINSON* SENIOR PRODUCT MANAGER T +1 925 396 1125 *E* doug.robin...@wandisco.com -- * <http://wandisco.com/>* **The *LiveData* Company *Find out more *wandisco.com <http://wandisco.com/>* <https://www.wandisco.com/liveanalytics> THIS MESSAGE AND ANY ATTACHMENTS ARE CONFIDENTIAL, PROPRIETARY AND MAY BE PRIVILEGED * If this message was misdirected, WANdisco, Inc. and its subsidiaries, ("WANdisco") does not waive any confidentiality or privilege. If you are not the intended recipient, please notify us immediately and destroy the message without disclosing its contents to anyone. Any distribution, use or copying of this email or the information it contains by other than an intended recipient is unauthorized. The views and opinions expressed in this email message are the author's own and may not reflect the views and opinions of WANdisco, unless the author is authorized by WANdisco to express such views or opinions on its behalf. All email sent to or from this address is subject to electronic storage and review by WANdisco. Although WANdisco operates anti-virus programs, it does not accept responsibility for any damage whatsoever caused by viruses being passed.