On Fri, Jan 17, 2020 at 10:36 AM Daniel Shahaf <d...@daniel.shahaf.name> wrote:
> Julian and I discussed this on IRC today; the conclusion is:
>
> - With the behaviour of the test with seed=0 having been manually
>   reviewed, we're satisfied that the test achieves adequate coverage.
>
> - The properties that the magic numbers were chosen to satisfy will be
>   documented in code comments.
>
> - Julian has further reviewed the code, leading to, e.g., r1872919.

For convenience, a link to an archive:
https://colabti.org/irclogger/irclogger_log/svn-dev?date=2020-01-17

Thanks,
Nathan

Reply via email to