James McCoy wrote on Sun, 16 Feb 2020 10:06 -0500: > However, the svn-x64-macosx-apr1.3-nothread buildbot informed me that > apr_pescape_shell() isn't available in that version. It wasn't added > until 1.5.0. > > Now we need to either: > > a) Raise the minimum APR version
apr 1.5.0 was tagged on 2013-11-13, so this should be fine, for 1.14 at least. > b) Conditionally use the new code when built against an acceptable APR > version and > i) maintain the status quo for anyone using latest svn with an 8 year > old version of APR or That would make svn's behaviour depend on the build-time version of libapr. I don't think that's a good idea. > ii) add a minimal version of APR's escaping code that can be used > when built again a pre-1.5.0 APR. That would work too, and may be the preferred solution for 1.10 if we intend to backport the fix there. Cheers, Daniel
