hartmannat...@apache.org wrote on Tue, 17 Mar 2020 18:36 -0000:
> 1.14 release notes: Document escaping of pathname args to $SVN_EDITOR
> 
> * docs/release-notes/1.14.html
>   (editor-filename-escaping): New section. Documents the pathname escaping
>     implemented in r1874057, r1874093, and r1875230.

Thanks!

> +<p>When invoking the user-defined <tt>$SVN_EDITOR</tt>, such as during

The editor may be configured in other ways: --editor-cmd,
--config-option=…:editor-cmd, $EDITOR.

Suggest to say "When invoking the user-defined editor", with or without
listing some of the ways in which the editor command may be specified.

> +interactive conflict resolution, Subversion now performs escaping of any
> +special characters in the pathname of the file to be edited. (See
> +<a href="http://svn.apache.org/r1874057";>r1874057</a>,
> +<a href="http://svn.apache.org/r1874093";>r1874093</a>, and
> +<a href="http://svn.apache.org/r1875230";>r1875230</a>.)</p>
> +
> +<p>Note that escaping is performed only on the pathname argument.
> +<tt>$SVN_EDITOR</tt> itself is not escaped: As before, the editor is invoked
> +through the shell and the user must properly escape/quote
> +<tt>$SVN_EDITOR</tt>. See the related FAQ
> +<a href="https://subversion.apache.org/faq.html#svn-editor";>"How do I deal
> +with spaces in the editor path?  Also, how can I define command line options
> +for the editor?"</a></p>

Add full stop after the closing quotation mark?

Add an example?  (An example is worth a thousand words…)

Cheers,

Daniel

> +</div> <!-- editor-filename-escaping -->
> +
>  <div class="h4" id="conflict-resolver">
>  <h4>Improvements to the interactive conflict resolver
>    <a class="sectionlink" href="#conflict-resolver"
> 
> 

Reply via email to