On 2020/04/19 3:26, Johan Corveleyn wrote: > On Fri, Apr 17, 2020 at 11:21 PM Yasuhito FUTATSUKI <futat...@poem.co.jp> > wrote: >> >> On 2020/04/17 5:53, Johan Corveleyn wrote: >> >>> Running the testsuite with Py 3.8.2 with PYTHONLEGACYWINDOWSSTDIO >>> defined in the environment allows it to complete. It results in 68 >>> FAILS (for ra_local x fsfs). See attached fails.log. >> >> I hope a part of the problems may fixed by attached patch, however, >> I can't see why these test was passed in Python 2.7. > > Thanks! That fixes two of the tests. These two now pass after applying > your patch (so feel free to commit -- I also checked again with Python > 2.7 and still all tests successful):
Thank you for testing. I commited it in r1876707. One more fix. > FAIL: blame_tests.py 18: blame_youngest_to_oldest The patch attached address to this one. Thanks, -- Yasuhito FUTATSUKI <futat...@yf.bsdclub.org>/<futat...@poem.co.jp>
Use svntest.main.file_write to avoid end of line conversion. * subversion/tests/cmdline/blame_tests.py (blame_youngest_to_oldest) Reported by: jcorvel Index: subversion/tests/cmdline/blame_tests.py =================================================================== --- subversion/tests/cmdline/blame_tests.py (revision 1876706) +++ subversion/tests/cmdline/blame_tests.py (working copy) @@ -958,8 +958,7 @@ sbox.simple_commit() #r3 # Delete a line. - with open(iota_moved, 'w') as f: - f.write(line) + svntest.main.file_write(iota_moved, line) sbox.simple_commit() #r4 expected_output = [
