On Wed, May 27, 2020 at 4:43 PM Nathan Hartman <hartman.nat...@gmail.com> wrote: > > On Tue, May 26, 2020 at 10:02 PM Yasuhito FUTATSUKI <futat...@poem.co.jp> > wrote: > > >> Should any of these be added to > > >> https://subversion.apache.org/docs/release-notes/1.14#issues ? > > > > > > Yes, all of them I think. > > > I thought first to wait whether we can still commit some / most of > > > them, and nominate for backport. It's easier to refer to revisions > > > than to patches. But OTOH we don't necessarily have to wait for that. > > > > Now I commited all my patches in above list, and nominated for back port, > > as a test suite fix group of patches (all my commit of my patch above > > are in this group). > > Were there any patches by Jun that still need to be committed / > nominated for backport? > > Nathan
Yes, these two patches are really also needed: > > - py38-windows-add-dll-directory--v2.diff posted by jun66j5 on 2020-05-11 > > in dev@ thread > > "[PATCH] fix unable to load *.pyd files with Python 3.8.x on Windows" (or a variation thereof ... I see that several patches were posted in that thread, I'm not sure anymore which is which :-)) > > - Patch remove-uses-of-os-dup2.diff posted by jun66j5 on 2020-05-08 in dev@ > > thread > > "Problems running testsuite on Windows with Python 3" (without this one, our python tests refuse to run if you start the testsuite without --log-to-stdout, unless you set the PYTHONLEGACYWINDOWSSTDIO envvar -- we can always mention this as a workaround though). I'd like to leave the honor to Jun to commit them :-). Of course it would be best for clarity of our release notes that you could refer to proper revisions, if possible. So I'm not sure how long you can wait for that, or that you should already include a reference to the patches as "wip" ... -- Johan
