Yasuhito FUTATSUKI wrote on Sun, 31 May 2020 19:03 +0900:
> On 2020/05/31 14:39, Yasuhito FUTATSUKI wrote:
> > 
> > I updated the patch.  
> 
> I found that subversion/bindings/swig/INSTALL still containd
> environment variable based methods, so I updated the
> patch again.
> 
> The difference from previous "fix_configure_patch2.txt" is following two
> hanks for subversion/bindings/swig/INSTALL:

"hunks" ☺

> [[
> @@ -209,10 +213,10 @@

[filtered through «wdiff -d»]

> *  Perl
> 
>    Perl 5.8.0 is required.  You can specify the perl binary by passing
>    [-PERL=/path/to/perl-]
>    {+--with-swig-perl=/path/to/perl+} as [-part-] {+an option+} of the 
> configure command
>    in the top level of the Subversion source tree.

This is grammatical as it stands, but I think s/an option of/an option to/
would better capture the intended meaning.

> I attached full diff, as fix_configure_patch3.txt.

Looks good to me.  Thanks!

Daniel

Reply via email to