Hi, On 2020/10/08 13:12, Jun Omae wrote: > Hi all, > > On Sun, Oct 4, 2020 at 11:33 PM Yasuhito FUTATSUKI <futat...@yf.bsdclub.org> > wrote: >> I commited the v3 patch in 1882234. >> >> I confirmed that on Windows in CP932, both of with and without >> the v3 patch, it cannot pass the file name to edit. >> >> For Windows I confirmed that it can be fixed by using _wsystem() >> with WCHAR string, so I commited it in 1882235. > > I found a minor issue on Windows after r1882235. > > When the editor command (via SVN_EDITOR environment and --editor-cmd option) > has > non-ascii characters, it is unable to launch the editor. > > I think we should convert the editor command to UTF-16 encoding before > passing it > to _wsystem(), otherwise r1882235 should be reverted.
I confirmed it is a regression that introduced in r1882235. So I reverted it in 1882313. Then I'll try to resolve it by the way you suggest. Thanks, -- Yasuhito FUTATSUKI <futat...@yf.bsclub.org>
