On Wed, Jan 27, 2021 at 2:40 AM Johan Corveleyn <jcor...@gmail.com> wrote: > > On Tue, Jan 26, 2021 at 9:56 PM Johan Corveleyn <jcor...@gmail.com> wrote: > > > > On Tue, Jan 26, 2021 at 7:43 PM Alexandr Miloslavskiy > > <alexandr.miloslavs...@syntevo.com> wrote: > > > > > > On 25.01.2021 1:55, Johan Corveleyn wrote: > > > > > > > As an update: I've started looking into this, but it's a bit more work > > > > than I anticipated. I want to understand and properly review the > > > > changes. > > > > > > Thanks! I already started thinking that all hope is lost :) > > > > > > The branch contains additional tests (added over a few commits). If you > > > keep the tests but discard my patches to JavaHL, you'll see the crashes. > > > With patches, crashes are no more. > > > > > > I tried to properly explain everything in code comments and commit > > > messages. However, if you have any questions, please ask, and I'll do my > > > best to explain. > > > > Great! Thanks for sticking around. I'll try to get through it all :-). > > Okay, I went through it all, and it looks good to me. Those are some > pretty delicate bugs / fixes, so thanks for explaining everything so > well in the comments and commit messages. Great work! > > Apart from reading the code, I've applied the tests and their fixes > individually to better understand them, and to make sure they first > failed on my system and were subsequently fixed by the corresponding > fix. After that, I'm satisfied that they are a good step forward. > > I did have a couple of tiny questions / remarks, but I'm going to get > back to them tomorrow, after another fresh look.
Done. @Alexandr: if you could please take a look at the small remarks / questions I raised on r1882520, r1882522 and r1882523, that would be great. Thanks, -- Johan
