Yasuhito FUTATSUKI wrote on Thu, Feb 25, 2021 at 21:43:15 +0900: > On 2021/02/22 13:39, Karl Fogel wrote: > > I felt I should close the loop in this thread: > > > > I decided to leave this be for now. Even though it is mildly annoying that > > the Subversion test suite exhibits a few spurious failures on systems that > > have only 'python3' and not 'python', it turns out that most of the time > > most of my systems have 'python'. So the real-world effects here are pretty > > minor for me, and apparently for others, and there are more important > > things I could work on in Subversion. If anyone wants to fix this minor > > problem, there are enough pointers in this thread I think. > > Then, I made patches. It also allows pypy to run the test without > 'python'. > > (A) Replace the shebang line of svneditor.py from svneditor.py > at running the configure script. (fix-svneditor-in-test-patch-a.txt) > As @PYTHON@ can be basename only, relative path, or absolute path, > "/usr/bin/env" is still needed. > > (B) Make a script to launch svneditor.py using @PYTHON@, svneditor.sh > at running the configure scriptt. (fix-svneditor-in-test-patch-b.txt) > > If @PYTHON@ is always absolute path, we can use shebang line without > '/usr/bin/env' in patch (A). > > Cheers,
I take it the two patches are alternatives? If so, I prefer (B), because: - .in files get in the way of the edit-compile-fix cycle, and the file that (B) makes .in is less likely to need to be edited. - Using @PYTHON@ in a #!/bin/sh script is closer to its existing uses (in Makefile.in, for example) than using it on the #! line.
