On 2021/05/18 12:46, Jun Omae wrote: > Hi, > > On Sun, May 9, 2021 at 3:18 AM Yasuhito FUTATSUKI > <futat...@yf.bsdclub.org> wrote: >> Jun found that an error message on failing editor invocation on >> commit/propchange or edit to resolve confilict is still corrupted if >> editor or file name contains non-ascii character and not in UTF-8 >> locale even after r1887641 on Windows (and perhaps on macOS). >> >> To reproduce it, in non UTF-8 CodePage/locale, set SVN_EDITOR to >> non existent path which contains non-ascii character and > > The patch looks good to me and verified with the following environments: > > * Windows 10 (cp932) > * Linux (ja_JP.eucjp) Thank you very much for the review and verification.
Commited in r1890013 and added to r1887641 group in 1.14.x back port nomination. Cheers, -- Yasuhito FUTATSUKI <futat...@yf.bsclub.org>
