Daniel Sahlberg wrote on Wed, 23 Jun 2021 21:44 +00:00: > I've committed r1891003. My makeup regex is probably not correct, feel > free to adjust it to something more proper.
The pattern matches release_x64_static and debug_x64_static, but they haven't been added to the property's value. Should they? As to the log message, the syntax of the multiple-filenames-describing thing doesn't matter too much; it's clear what you meant, and that's what matters. For reference, something like "Ignore TortoiseSVN build directories", without naming the directories at all, would have been acceptable too (which, incidentally, is why the "Don't hide names in wildcards" rule in HACKING doesn't apply too strongly in this case). I suppose that's a use-case for being able to «blame» property values. Calling «[release|debug]_[win32|x64][_static]» a regex is a bit confusing, since in most/all regex flavours, an unescaped square bracket denotes an "any one of the following characters" alternation. It _is_ a regex, in that it matches strings using literals, alternations, and Kleene stars, but matching the description "My regex" against the log message did involve some backtracking ;-) Cheers, Daniel
