On Sat, Jan 1, 2022 at 4:44 PM Daniel Sahlberg <daniel.l.sahlb...@gmail.com> wrote: > > Thank you both for your input. Answers inline below! > > Den lör 1 jan. 2022 kl 17:16 skrev Daniel Shahaf <d...@daniel.shahaf.name>: >> >> Nathan Hartman wrote on Fri, 31 Dec 2021 00:01 +00:00: (snip) >> > I am slightly worried, though, that "-o bashdefault" might be a >> > bashism not compatible with all systems or shells. >> >> Isn't tools/client-side/bash_completion specific to bash? > > > The script says: > [[[ > Known to work with bash 3.* with programmable completion > ]]] > > This was changed in r877553 in 2009 when svndumpfilter was added. I don't > know if it was required or if it was changed because bash 3 (released in > 2004) at that time was mature/common. > > I've checked and according to the bash CHANGES file, bashdefault was added in > bash 3. So by adding the option we are not even incrementing the required > bash version from what is already documented.
Well, the above pretty much answers my concerns, so I'm +1 to commit and close out this issue. Happy New Year, Nathan
