Jun Omae wrote on Sat, Feb 05, 2022 at 00:28:51 +0900: > After r1897443, prop_tests.py 12 is failing on Windows. > > svntest.Failure: Repository diskpath in stderr: [ > "svn: E175008: While handling the 'cash-sound' property on > '/svn-test-work/repositories/prop_tests-12/!svn/bln/0':\n", > 'svn: E175008: Revprop change blocked by pre-revprop-change hook (exit code > 1) with output:\n', > 'pre-revprop-change > D:\\a\\subversion\\subversion\\Release\\subversion\\tests\\cmdline\\svn-test-work\\repositories\\prop_tests-12 > 0 jrandom cash-sound A\n'] > FAIL: prop_tests.py 12: set, get, and delete a revprop change > ⋮ > I think we could use %2 .. %5 variables instead of %* variable. ⋮ > Or we could simply remove `cmd_alternative` parameter.
Thanks, Jun. As I don't have a Windows build environment and we don't have Windows buildbots either, so I can't debug this myself. Both of your alternative patches seem reasonable. I like how the latter removes the need to maintain two separate implementations (.py and .bat) of identical functionality. However, at the end of the day, I'll be happy with any solution that works for Windows-based devs. Could someone test and commit those Windows-only patches, please? Thanks! Daniel (not 100% here today)
