> On 2 Sep 2022, at 15:09, Nathan Hartman <hartman.nat...@gmail.com> wrote: > > >> >> On Mon, Aug 29, 2022 at 5:36 AM Barry Scott <ba...@barrys-emacs.org> wrote: >> I had a pysvn user report that they cannot detect that a wc is locked. >> >> What I found is that I get that info and indeed locked == 0. >> >> This is because there is no code in svn_wc__status2_from_3 to >> copy locked value from old_status->locked into *status->locked. > > Hi Barry, > > Are you able to check whether the attached one-line patch fixes the > issue?
Yep, I build subversion myself, so can add your patch and test. > > Caveat: I intended to implement a regression test and verify the fix > with the test suite but haven't gotten around to it yet. For now the > fix is on a branch: > https://svn.apache.org/repos/asf/subversion/branches/issue-4908 > > Notes: While investigating this, I discovered that we are also not > copying file_external. It appears that all other fields are being > copied. How do I force the working copy into the locked state? I did it by accident before and did the debug with that, Barry > > Cheers, > Nathan
Index: subversion/libsvn_wc/deprecated.c =================================================================== --- subversion/libsvn_wc/deprecated.c (revision 1903831) +++ subversion/libsvn_wc/deprecated.c (working copy) @@ -2815,6 +2815,7 @@ } (*status)->entry = entry; + (*status)->locked = old_status->locked; (*status)->copied = old_status->copied; (*status)->repos_lock = svn_lock_dup(old_status->repos_lock, result_pool);