Good job (but I haven't reviewed the details) =)
/Daniel Den mån 21 nov. 2022 kl 16:09 skrev <kot...@apache.org>: > Author: kotkov > Date: Mon Nov 21 15:09:14 2022 > New Revision: 1905438 > > URL: http://svn.apache.org/viewvc?rev=1905438&view=rev > Log: > On the 'pristines-on-demand-on-mwf' branch: Remove XFail() markers from > several file externals tests. The underlying issue was resolved by > r1905436 > in trunk. > > * subversion/tests/cmdline/externals_tests.py > (update_modify_file_external, > remap_file_external_with_prop_del, > file_external_recorded_info): Remove XFail() markers. > > Modified: > > subversion/branches/pristines-on-demand-on-mwf/subversion/tests/cmdline/externals_tests.py > > Modified: > subversion/branches/pristines-on-demand-on-mwf/subversion/tests/cmdline/externals_tests.py > URL: > http://svn.apache.org/viewvc/subversion/branches/pristines-on-demand-on-mwf/subversion/tests/cmdline/externals_tests.py?rev=1905438&r1=1905437&r2=1905438&view=diff > > ============================================================================== > --- > subversion/branches/pristines-on-demand-on-mwf/subversion/tests/cmdline/externals_tests.py > (original) > +++ > subversion/branches/pristines-on-demand-on-mwf/subversion/tests/cmdline/externals_tests.py > Mon Nov 21 15:09:14 2022 > @@ -1632,8 +1632,6 @@ def merge_target_with_externals(sbox): > " /A-branch:8\n"], > [], 'pg', svntest.main.SVN_PROP_MERGEINFO, '-vR', wc_dir) > > -# Existing issue: `src_stream` not closed in externals.c:apply_textdelta() > -@XFail(svntest.main.is_os_windows) > def update_modify_file_external(sbox): > "update that modifies a file external" > > @@ -2799,8 +2797,6 @@ def shadowing(sbox): > # Test for issue #4093 'remapping a file external can segfault due to > # "deleted" props'. > @Issue(4093) > -# Existing issue: `src_stream` not closed in externals.c:apply_textdelta() > -@XFail(svntest.main.is_os_windows) > def remap_file_external_with_prop_del(sbox): > "file external remap segfaults due to deleted props" > > @@ -4178,8 +4174,6 @@ def file_external_to_normal_file(sbox): > expected_status) > > @Issue(4580) > -# Existing issue: `src_stream` not closed in externals.c:apply_textdelta() > -@XFail(svntest.main.is_os_windows) > def file_external_recorded_info(sbox): > "check file external recorded info" > > > >