Den tis 18 juli 2023 kl 21:23 skrev Yasuhito FUTATSUKI < futat...@yf.bsdclub.org>:
> Hi, > > On 2023/06/25 19:22, Daniel Sahlberg wrote: > > Den ons 31 maj 2023 kl 05:29 skrev Yasuhito FUTATSUKI < > > futat...@yf.bsdclub.org>: > > > >> Hello, > >> > >> On 2023/05/30 17:04, Daniel Sahlberg wrote: > >> > Den tis 30 maj 2023 kl 04:46 skrev Jun Omae <jun6...@gmail.com>: > >> > > > > [...] > > > > > >>>> However, in attached patch, correct the escape sequences because "make > >> >> check" requires at least Python 3.0. > >> > >> In the discussion in this list at 2019, there is no objection that > >> we don't support Python 3.x where x < 5, both in trunk and 1.14.x. > >> And since r1899944, we drop Python 2.7 support for make check, in trunk. > >> > >> So I think it can be accectable, at least trunk. > >> > >> However we've not drop Python 2.7 support agressively, using 'br' prefix > >> instead of 'rb' is prefered if we want back porting this to 1.14.x. > >> Because 'br' prefix can be also used in Python 2.7. > >> > >> > > I don't think this change was ever committed. Can we come to a conclusion > > on how to do it and get it committed? > > I'm very sorry for replying too much late, but I don't think my post has > been blocking to commit any of them. Any of three looks good to me. > Let's go ahead. > > > In my opinion this change doesn't need to be backported to 1.14 so we can > > go with a Python 3-only solution. My reasoning is that it "only" fixes a > > SyntaxWarning so it isn't a very significant issue. By the time Python > > changes to a SyntaxError, I hope 1.14 is EOL anyway. > > Even if it won't be backported to 1.14.x, there is no reason to avoid using > br'...', but also there is no strong reason to use it. > > A small reasons are that we've already used br'...' in > subversion/tests/cmdline/svntest/tree.py, and I believe that using raw > prefix > in regular expression string rather than using backslash escape is good for > readability. I'm not fluent in Python to the level of these changes (although as far as I've been able to test they are good). Could one of you commit? Kind regards, Daniel
