Hi,

Issue SVN-1778 [1] is about the Python bindings, class FileDiff, where
get_pipe() called an external program diff (under Windows: diff.exe). Since
diff.exe has to be installed (and added to PATH) manually on Windows the
function would fail. The same is true on other os:es but diff is probably
more commonly present by default.

r1824410 added support for running the internal Subversion diff functions
(svn.diff.file_diff_2 and svn.diff.file_output_unified4) as long as the
argument diffoptions is None (the default). Since diffoptions is passed as
arguments to the diff command, it seems reasonable to require the presence
of diff (or diff.exe) if one uses diffoptions.

I'm suggesting to close this issue - it is not completely solved but when
using diffoptions,it is probably expected that this arguments is passed on
to whatever diff/diff.exe executable is present on the system and thus it
is not unreasonable to require the end user to install diff.exe

Kind regards,

Daniel Sahlberg

[1] https://issues.apache.org/jira/browse/SVN-1778

Reply via email to