Den sön 12 nov. 2023 kl 07:18 skrev Nathan Hartman <hartman.nat...@gmail.com >:
> On Fri, Nov 10, 2023 at 9:16 AM Daniel Sahlberg > <daniel.l.sahlb...@gmail.com> wrote: > > > > Den fre 10 nov. 2023 kl 15:09 skrev Nathan Hartman < > hartman.nat...@gmail.com>: > >> > >> On Fri, Nov 10, 2023 at 8:02 AM Johan Corveleyn <jcor...@gmail.com> > wrote: > >>> > >>> Hi Nathan, > >>> > >>> Sorry I haven't helped so far ... I should be able to say something > >>> useful here, since I'm a java dev in my dayjob. But I have been > >>> drowning a bit in that same dayjob lately, so I can barely find the > >>> time to scan these mails, and then forget about them because my > >>> attention is needed elsewhere. > >>> > >>> Anyway, I'll try to find some more time to take a closer look at the > >>> errors you get. > >>> > >>> Just as a first shot: if there is no RunTests.class in the location > >>> where it should be (one of the directories in the classpath), then it > >>> probably has not been compiled (or it has not been put in the right > >>> location). My first guess would also be, like Daniel mentioned, that > >>> you'll need the --with-junit option (referring to a junit-X.Y.jar > >>> somewhere on your system) and then the build scripts should compile > >>> the test classes. > >>> > >>> But I guess you already tried that, after Daniel's reply, and you're > >>> still running into problems. I'll take a closer look when you send > >>> your detailed mail then. > >>> > >>> -- > >>> Johan > >> > >> > >> > >> Thanks Johan. Apologies for not sending the detailed mail yet. I wanted > to test a few specific theories but didn't get that far last night because > I hit a problem unrelated to SVN. > >> > >> One thing I'm struggling with is to understand which part of the build > system is supposed to compile RunTests, i.e., how/where the Java compiler > is being invoked on it. I'm not seeing it in the build logs, though I do > see the other Java files being compiled, so that's certainly interesting. > > > > > > I'm fairly sure that RunTests is compiled only when --with-junit is > present (don't know if "present" is enough or if it has to point to a valid > JAR file). Next question is if check-javahl should be available at all if > --with-junit is missing or if check-javahl should make sure RunTests is > built. Either way, I think it is a bug in the build system. This question > should probably be carved out to its own e-mail thread. I'll try to figure > something out and start a new thread. > > > > Kind regards, > > Daniel > > Hi all, > > Success! I have finally seen the JavaHL tests build and run! > > I'd like to say a great big Thank You to everyone for helping me get > this far! > > [...] > > (3) Worked around a problem with serf-1.3.10 that DSahlberg saw also. > > [...] > Regarding #3: > > When building serf-1.3.10, this warning foreshadows problems to come > later: > > buckets/ssl_buckets.c:1193:9: warning: implicit declaration of > function 'CRYPTO_malloc_init'; did you mean 'CRYPTO_malloc'? > [-Wimplicit-function-declaration] > > Later, when trying to link SVN, this linker error happens: > > /usr/bin/ld: /home/nathan/ramdrive/svndev/prefix/serf/lib/libserf-1.so.1: > undefined reference to `CRYPTO_malloc_init' > collect2: error: ld returned 1 exit status > make[1]: *** [build-outputs.mk:1140: subversion/svn/svn] Error 1 > make[1]: Leaving directory '/home/nathan/ramdrive/svndev/svn-1.14.x' > make: *** [Makefile:1845: > /home/nathan/ramdrive/svndev/objdir/svn-1.14.x/.compiled] Error 2 > > For several years, I have been self-building SVN with serf-1.4.x and > running the test suite successfully with that. I'm referring to serf's > branches/1.4.x, last changed rev r1845547. > Note that serf 1.4 is build using CMake so things might behave differently compared to SCons. > IIRC this was suggested by Brane and it's on my TODO list to locate > that conversation in the archives to see whether that was for this same > reason. > > Perhaps something can be backported to serf-1.3.x to solve this. It > manifests on recent Debian (DSahlberg reproduced this also [3]). > I did some more digging this morning and Nathan was onto something on IRC [1] when he disabled the merge of the serf/branches/1.3.x-sslbuild branch. It seems this branch mess things up when building on Debian. Some parts of the branch are probably needed (including some updates to SConstruct to handle building with Python3 when building 1.3.9) but it seems that some changes conflict with improvements in later versions of Serf. I plan to dig deeper (including setting up OpenBSD and test with LibreSSL) to see if we can simplify the -sslbuild branch or even upstream some of the changes. Kind regards, Daniel [1] https://colabti.org/irclogger/irclogger_log/svn-dev?date=2023-11-12
