On Sat, Jun 1, 2024 at 4:09 PM Timofey Zhakov <t...@chemodax.net> wrote:
>
> Hi all,
>
> In one of my previous patches, I factored-out the
> svn_opt_parse_change_to_range
> from the svn program into the libsvn_subr library and added unit tests on it.
> However, a similar code block exists in the svnbench program, so I think
> it could be replaced with this function.
>
> [[[
> Use svn_opt_parse_change_to_range function to parse the --change
> argument in the svnbench program.
>
> In r1918076, the svn_opt_parse_change_to_range function was
> factored-out from the svn program into the libsvn_subr library.
> Since the same functionality is needed for parsing the same argument
> in the svnbench program, we can use this function there as well.
>
> Additionally, this refactoring would fix some parsing bugs related to this
> argument, which were resolved in the svn program [1], but still exist in the
> svnbench program, because this code was duplicated.
>
> * subversion/svnbench/svnbench.c
> (sub_main): Replace the code that parses the --change argument with
> svn_opt_parse_change_to_range function.
>
> [1] The fixes in the --change argument parser were committed in
> r1917944 and r1917864.
>
> Patch by: Timofey Zhakov (tima {at} chemodax _dot_ net)
> ]]]
>
> Thanks!
>
> --
> Timofei Zhakov
Committed in r1918181.
Thanks!
Nathan
