I also made a "review" in Github but it seems that wasn't forwarded to the list so I'll copy-paste it below:
Thank you for the patch! I understand the idea of the patch but I'm not sure I think this implementation is a good idea. As noted in the code (lines 169-171) the format is the same as svn status. Changing the output format will break any scripts relying on parsing the text output. Of course, that could be acceptable, but the bar should be quite high in my opinion. The extra column will be output both in svn diff [working copy path] and svn diff [url]. When operating on a wc path, the extra data will be the same (plus leading and trailing single quote). When operating on a URL, the extra data will be the path component of the url, without url encoding. The new format would be very hard to parse: Spllitting on space will not work if the path contains a space (it will be output verbatim at LEAST in the second component). Splitting on single quote will not work if the path contains a single qoute. All in all, I'm -0 to accept this patch: I don't agree but I wouldn't stand in the way of consensus. Cheers, Daniel
