Re: svn commit: r1925722 - in /subversion/branches/utf8-cmdline-prototype/subversion: include/svn_client.h libsvn_client/cmdline.c

[Branko Čibej]

On 26. 5. 25 23:15, Timofei Zhakov wrote:
On Mon, May 26, 2025 at 10:07 PM Branko Čibej <br...@apache.org> wrote:
    On 26. 5. 25 21:25, Timofei Zhakov wrote:
    On Mon, May 26, 2025 at 8:29 PM Branko Čibej <br...@apache.org>
    wrote:

        On 26. 5. 25 14:07, Timofei Zhakov wrote:


    This is exactly what happened with
    svn_cmdline__get_cstring_argv(). I added a new function
    svn_cmdline__get_utf8_argv(), that returns a utf8 string instead.
    Then we can switch the one used in each executable one-by-one.

    Those are private functions, you can do whatever you want with
    them, as long as you end up with only one version of each instead
    of, I dunno, five.


Those are also transitional functions needed to migrate all usages 
smoothly. Probably it makes sense to drop the old ones then, but it 
would not be a big deal for us in future...


We have, what, 11 command-line tools? That's 11 one-line changes to make 
the transition to the correct behaviour. It doesn't have to be done all 
at once, but it shouldn't take years, either. Once all of those are 
fixed, we should remove the unused private functions. If we make any new 
command-line tools, we'll just have to get it right the first time. :)

-- Brane