On 26. 5. 25 21:55, rin...@apache.org wrote:
Author: rinrab
Date: Mon May 26 19:55:30 2025
New Revision: 1925841
URL:http://svn.apache.org/viewvc?rev=1925841&view=rev
Log:
On the 'utf8-cmdline-prototype' branch: follow-up to r1925834: prevent 'log
message is pathname' warning from showing when the log message is empty.
Modified:
subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c
Modified: subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c
URL:http://svn.apache.org/viewvc/subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c?rev=1925841&r1=1925840&r2=1925841&view=diff
==============================================================================
--- subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c (original)
+++ subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c Mon May 26
19:55:30 2025
@@ -3163,26 +3163,33 @@ sub_main(int *exit_code,
{
apr_finfo_t finfo;
- err = svn_io_stat(&finfo, opt_state.message, APR_FINFO_MIN, pool);
-
- if (!err)
+ /* We don't want to warn for '' */
+ if (opt_state.message[0] != '\0')
So now you need more code to fix a side effect from r1925834.
svn_io_stat() interprets "" as the current directory, apr_stat() does not.
I like the special-casing of the error for lock comment vs. log message,
but such changes that are unrelated to what you're doing on the branch
should really be done on trunk, it makes the merge review a little
easier later on.
-- Brane
