On 9. 6. 25 18:43, Timofei Zhakov wrote:
We're including apr_xlate.h for a couple of macros in
subversion/include/svn_utf.h, we need /only/ the header, not the
whole library. But CMake in its wisdom doesn't make the include
path available unless the target its building /links/ with
apr-util. This is just plain (censored) and wrong. Sure we can
patch build.conf to make this issue go away; but we won't. See
below, I had to do this to get even a minimal build working; none
of the targets I had to add the apr-util dependency to actually
uses anything from libaprutil. Such a change is therefore not
acceptable.
We no longer need it since 1926293 <https://svn.apache.org/r1926293>.
Hope this is helpful.
I vetoed that change. See my other mail as to why.
However, I think we can also define apr and other dependencies as
PUBLIC in terms of cmake, so we won't run into this problem again,
since we use them in our public headers.
If the APR dependencies are currently private in cmake, then that's a
problem in itself. Those include paths must always be available, not
just for our own build but for downstream consumers, too.
-- Brane
