On 26. 6. 25 22:35, Daniel Sahlberg wrote:
Hi Jun,
Thanks for testing!
Den tors 26 juni 2025 kl 05:02 skrev Jun Omae <jun6...@gmail.com>:
Also, the searching libraries using pkg-config doesn't work on my
environment. I think it is caused by the prefix passed to
pkg_check_modules is wrong.
[[[
diff --git a/CMakeLists.txt b/CMakeLists.txt
index e60809b1e..d94c30b14 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -269,8 +269,8 @@ if(SVN_USE_PKG_CONFIG)
# apr-1
add_library(external-apr ALIAS PkgConfig::apr1)
- pkg_check_modules(aprutil-1 REQUIRED IMPORTED_TARGET apr-util-1)
- add_library(external-aprutil ALIAS PkgConfig::aprutil-1)
+ pkg_check_modules(aprutil1 REQUIRED IMPORTED_TARGET apr-util-1)
+ add_library(external-aprutil ALIAS PkgConfig::aprutil1)
else()
# apr-2
pkg_check_modules(apr2 REQUIRED IMPORTED_TARGET apr-2)
]]]
I can't quite wrap my head around the function of the prefix In my
testings, it didn't really seem to matter what the prefix was. Expert
opinions welcome...
By the way, I noticed that the CMake build is consistently,
intentionally behaving differently from the autotools build: autotools
look for serf-2 before serf-1 and apr-2 before apr(-util)-1, CMake does
the opposite. I have no idea why, except maybe stubbornness.
[...]
[[[
24: svn_tests: E200006: Expected error SVN_ERR_SQLITE_BUSY but got
SVN_ERR_SQLITE_ERROR
24: svn_tests: E200030: sqlite[S3850]: disk I/O error
24: svn_tests: E200042: Additional errors:
24: svn_tests: E200030: sqlite[S3850]: disk I/O error
24: svn_tests: E200044: SQLite transaction rollback failed
24: svn_tests: E200030: sqlite[S1]: cannot rollback - no
transaction is active
24: svn_tests: E200030: sqlite[S1]: cannot rollback - no
transaction is active
]]]
Not sure if you intended this to be included in the patch or if it was
just temporary during debugging.
It would be nice to have this always available in the code, enabled at
compile-time (with or separately from --enable-debug).
-- Brane
