gstein commented on PR #33:
URL: https://github.com/apache/subversion/pull/33#issuecomment-3049649409

   Re-using the "defaults" variable for other purposes made the code confusing, 
especially with the "fall through" to where the comment mentions nothing to add.
   
   I used Daniel's original form, with a new dict named "merged" which is 
explicitly returned in the if-branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to