Hello, On 2025/07/25 22:36, Joe Orton wrote: > On Fri, Jul 25, 2025 at 12:37:56AM +0900, Yasuhito FUTATSUKI wrote: >> Thank you for testing. >> >> The intention of those tests are detection of extra reference >> remaining after calling callback functions. However, with deferred >> reference counting and biased reference counting, it cannot work >> as I(we?) expected. So I don't think the changes on r1926575 is >> correct if no one cannot explain why this part of the test could >> pass without modifying expected refcount. >> >> I propose: >> >> * Use weakref for the tests of this purpose >> * Until those test is rewrited with using weakref, simply skip >> them on Python >= 3.14. > > Thanks for looking at this, that seems reasonable to me. The attached > reverts r1926575 and adds skipIf decorators, does it look correct? I'll > run it through a build too.
The patch looks good. Also, I've run check-swig-py on Python 3.11 and it did not skip those tests as we expected. Thanks, -- Yasuhito FUTATSUKI <futat...@yf.bsdclub.org>
