On Tue, Jul 29, 2025 at 2:50 AM Daniel Sahlberg <daniel.l.sahlb...@gmail.com> wrote:
> Hi everyone, > > (Crossposting to dev@serf and dev@subversion since it is the same for both > communities). > > When we get pull requests in GitHub for either project, we still have to > download the patch and commit manually to Subversion. In the log message, > we can use the special syntax "This fixes #NNN in GitHub" (or, I believe, > "Closes #NNN") where NNN is the PR number. See Subversion's HACKING[1]. > This has to be in the initial log message, it doesn't help to add it later > by editing the log message. > > If we for some reason want to close the PR without making a commit (or > we've made the commit and forgot to add the log message), we have to do > this directly in GitHub. This requires the Triage role (authz bit) in > GitHub on your GitHub account. To get this we have to request it > user-by-user from Infra, see the reply by GavinMcDonald in JIRA[2]. > > It doesn't seem like Infra require any particular discussion/vote about > this so I assume they just verify that a request comes from a committer in > that particular project. > > I'm going to put in a request for myself in Serf (I already have that role > in Subversion), if anyone else wants to join please chime in so we can > request everyone at the same time. (I plan on sending the request on > Friday). > > Cheers, > Daniel > > > [1] > https://subversion.apache.org/docs/community-guide/conventions.html#github > [2] https://issues.apache.org/jira/browse/INFRA-27048 > Hi, Thanks for posting the explanation/reminder. I already have the triage roll in Subversion; feel free to add me to the request for Serf. If the quantity of GitHub PRs continues to increase across the two projects, maybe it would be worthwhile to write a script that downloads the patch and commits it with the special syntax included. Thanks, Nathan
