Den tis 30 dec. 2025 kl 18:58 skrev Branko Čibej <[email protected]>:
> On 30. 12. 25 18:36, Daniel Sahlberg wrote: > > Den tis 30 dec. 2025 kl 17:36 skrev Timofei Zhakov <[email protected]>: > > ... > - It's a great idea to "steal" optimized hash implementation, so we'd >> get that performance boost without requiring any third-party >> libraries. I think AWS-LC would be more suitable for this purpose >> because it bundles pre-generated assembly sources whereas OpenSSL >> needs perl for that. >> > > I would not want to copy an existing implementation (including significant > ASM code). That would open us up for a major investment in maintenance. I > think we should keep the project simple by interfacing with external > libraries that do this better, in line with the Unix philosophy of doing > one thing and doing it well. > > > Think of it as another SQLite amalgamation or utf8proc. It's not *that* much > work once it's imported and spliced into the builds. > > (Which reminds me, someone should upgrade the built-in utf8proc before the > next release. That, or we should make it a mandatory dependency, it's not a > rare beast any more, even on Windows.) > I think you sort of made my point here: If we copy an external implementation as we've done with utf8proc, we need to make sure it is kept up-to-date. I'm still not convinced that implementing support for a multitude of different checksum providers in SVN makes sense. Of course, if APR decide to take it under their wings, someone would have to maintain it there but there is a benefit for all other APR-using projects. (Btw; I went ahead and asked on the APR mailing list: https://lists.apache.org/thread/bp5zyycdrlyszy83f0rxvjjv66s6bzts, no replys yet). Cheers, Daniel
