Re: svn commit: r1931019 - in subversion/trunk: . subversion/include subversion/libsvn_subr

[Timofei Zhakov]

On Mon, Jan 12, 2026 at 2:25 PM Evgeny Kotkov via dev
<dev@subversion.apache.org> wrote:
>
> Timofei Zhakov <rin...@apache.org> writes:
>
> +static svn_error_t *
> +bcrypt_ctx_update(bcrypt_ctx_t *ctx,
> +                  const void *data,
> +                  apr_size_t len)
> +{
> +  SVN_ERR_ASSERT(len <= ULONG_MAX);
> +
> +  SVN_ERR(handle_error(BCryptHashData(ctx->handle,
> +                                      (PUCHAR) data,
> +                                      (ULONG) len,
> +                                      /* dwFlags */ 0)));
> +
> +  return SVN_NO_ERROR;
> +}
>
> Perhaps, we could add a loop here to have correct behavior in a potentially
> possible case when `len` exceeds ULONG_MAX?

Sorry, I lost this thread...

+1

There is a patch for the APR backend at [1]. Thanks!

[1] https://lists.apache.org/thread/6g6yl073p8gq3k8hyjyxy82qlsjosok7


--
Timofei Zhakov