On 30. 1. 26 20:19, Daniel Sahlberg wrote:
I have voted for this in r1931614.


     * r1931265
       Newest OpenSSL/httpd does not like server certificates with
    tiny keys.

     * r1931266
       In Python 3, hashlib input data must be byte strings, not Unicode.

     * r1931298, r1931552
       Update an omission in a docstring.


I think we should approve it even though it only has two +1 for the full backport. r...552 is only formatting and the whole backport is only documentation. However maybe Nathan could upgrade his vote...


I'll chime in here, since this is my fiddling. -265 and -266 are only necessary if anyone wants to 'make davautocheck USE_SSL=1' with a Serf build that uses anything resembling a modern OpenSSL – that would be 3.x. I only noticed because I was testing with Serf trunk/future 1.5 with SVN__SERF_EXPERIMENTAL enabled and OpenSSL 3.6.



     * r1931334, r1931337, r1931359, r1931369, r1931373
       Remove a potentially data-truncating typecast in our adler32
    implementation



This is just pedantic OCD spit&polish on my part. Not strictly necessary for .0 since there's no regression, nice to have. Was a result of my playing around on the better-pristines branch and noticing yet another unchecked truncating cast and ... well, the rest is history. There's also a 1.4.x backport branch for this way too large group of commits.


-- Brane

Reply via email to