On Wed, Feb 4, 2026 at 1:52 PM Jun Omae <[email protected]> wrote: > > On 2026/02/04 1:51, Timofei Zhakov wrote: > > > > Committed in r1931690. > > > > -- > > Timofei Zhakov > > [[[ > - find_package(Serf REQUIRED) > + find_package(Serf REQUIRED 1.3.4) > ]]] > > In r1931690, 1.3.4 argument has been added to find_package(Serf ...) > but the version checking doesn't work. In fact, even if the version > "1.3.4" of 3rd argument is replaced with "99.0.0", cmake will not > stop. > > Should be ([version] argument should be 2nd argument): > > [[[ > - find_package(Serf REQUIRED 1.3.4) > + find_package(Serf 1.3.4 REQUIRED) > ]]] > > See also [1]. > > [1] > https://cmake.org/cmake/help/latest/command/find_package.html#typical-usage > > -- > Jun Omae <[email protected]> (大前 潤)
I missed that... The assert was broken when I was testing that. Followed up the fix in r1931732. Thanks so much for noticing! -- Timofei Zhakov
