On 18. 2. 26 17:49, Daniel Sahlberg wrote:
Hi,
There was a message on the TortoiseSVN mailing list suggesting to add
cmd.exe based hook script templates to repositories created on Windows[1].
I think it was a great suggestion and I started thinking about how it
should be implemented.
We currently create /bin/sh based hook script templates (see around
line 392 in repos.c[2]). sh (bash) is not generally available on
Windows and from what I can tell there would at least be some path
style conversion issues (c:\repositories\xyz\ vs. /c/repositories/xyz/).
I see two options - on Windows:
1. Keeping the existing sh based templates and adding cmd.exe based
templates as well.
2. Creating only cmd.exe based templates.
(On other platforms there would be no change in behaviour).
I think option 2 makes more sense, but maybe it would be
"non-backwards compatible" if we stop offering the sh templates. OTOH
I don't see how they would have worked anyway.
Thoughts?
The only thing that would make sense in a cross-platform kind of way
would be to convert those templates to Python. and use that on all
platforms. Just as we do in our test suite.
-- Brane
