On Tue, Mar 3, 2026 at 2:55 PM Evgeny Kotkov <[email protected]> wrote:
> Timofei Zhakov <[email protected]> writes: > > > I prepared a patch that fixes them by adding const where needed. Can > anyone > > correct me if I'm misunderstanding something? > > I think that the patch indeed improves the situation by propagating the > non- > const types upwards, so that everything happens without implicit const > discards. So +1 in general. > > One suggestion that I have is that it might be better to separate the > simpler > cases (like those in libsvn_fs/fs-loader.c:svn_fs__path_valid() and > libsvn_fs_fs/tree.c:check_newline()) into their own patch or commit, > keeping them distinct from the more complex cases. > +1, to separate those changes. -- Timofei Zhakov
