On Sat, 9 May 2026 at 13:51, Daniel Sahlberg <[email protected]> wrote:
> Den fre 8 maj 2026 kl 21:24 skrev Daniel Sahlberg < > [email protected]>: > > > > Crossposting between dev@subversion and dev@serf: This is an error in > > Subversion's GHA build but it is caused by an issue in Serf's build > > system. > > > > Den fre 8 maj 2026 kl 20:11 skrev GitBox <[email protected]>: > > > > > > > > > The GitHub Actions job "CMake" on subversion.git/trunk has failed. > > > Run started by GitHub user asf-gitbox-commits (triggered by > asf-gitbox-commits). > > > > > > Head commit for run: > > > 33480bcd3d11768caa4fd801fc00a845c1bf607b / Daniel Sahlberg < > [email protected]> > > > * .github/workflows/cmake.yml: Attempt to fix Window build on GitHub > Actions. > > > > > > Shamelessly borrowed from r1933912 in APR (by Ivan) > > > > > > git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1933957 > 13f79535-47bb-0310-9956-ffa450edef68 > > > > > > Report URL: > https://github.com/apache/subversion/actions/runs/25571122451 > > > > > > With regards, > > > GitHub Actions via GitBox > > > > > > > Copying from the GHA log: > > > > [[[ > > scons-dbg-err.log > > scons: *** Invalid value for enum variable 'MSVC_VERSION': '14.5'. > > Valid values are: ('14.3', '14.2', '14.1', '14.0', '12.0', '11.0', > > '10.0', '9.0', '8.0', '6.0') > > File "C:\vcpkg\buildtrees\serf\src\serf-1-659141d597.clean\SConstruct", > > line 164, in <module> > > Completed submission of openssl:[email protected] to 1 > > binary cache(s) in 8.7 s > > Completed submission of zlib:[email protected] to 1 binary > > cache(s) in 119 ms > > Error: Process completed with exit code 1. > > ]]] > > > > This is fixed in Serf/trunk in r1933327. I've nominated this as a > > backport to 1.3.x in r1933963 but we obviously need to make a new > > release of Serf to resolve it. > > > > I don't know if Subversion can patch the vcpkg package or if it is > > possible to patch the vcpkg package itself. > > I took a look at the vcpkg package and there is already another patch > so I followed that model and created a PR: > https://github.com/microsoft/vcpkg/pull/51629 > > Hi Daniel, Yes, patches is typical thing for vcpkg packages. Minor comments regarding PR: 1. As far as I know port-version in vcpkg.json <https://github.com/d-sahlberg/vcpkg/blob/a8f4b3627144b27fae2bf4bf70dac70171f480b8/ports/serf/vcpkg.json> should be incremented if port changed without changing version field. 2. I suggest to rename vs_2026.diff to something like serf-r1933327.diff. Besides of that PR looks good to me. -- Ivan Zhakov
