Re: svn commit: r1936132 - subversion/trunk/build/generator

[Timofei Zhakov]

On Tue, Jul 14, 2026 at 3:48 PM <i...@apache.org> wrote:

> Author: ivan
> Date: Tue Jul 14 13:48:03 2026
> New Revision: 1936132
>
> Log:
> cmake: Sort CMake target conditions to generate stable targets.cmake.
>
> Found by: brane
>
> * build/generator/gen_cmake.py
>   (Generator.write): Sort result of `list(set())` to have stable order of
>    target conditions.
>
> Modified:
>    subversion/trunk/build/generator/gen_cmake.py
>
> Modified: subversion/trunk/build/generator/gen_cmake.py
>
> ==============================================================================
> --- subversion/trunk/build/generator/gen_cmake.py       Tue Jul 14
> 10:59:01 2026        (r1936131)
> +++ subversion/trunk/build/generator/gen_cmake.py       Tue Jul 14
> 13:48:03 2026        (r1936132)
> @@ -214,7 +214,7 @@ class Generator(gen_base.GeneratorBase):
>          else:
>            install_target = False
>
> -        enable_condition = list(set(enable_condition))
> +        enable_condition = sorted(list(set(enable_condition)))
>          if len(enable_condition) > 0:
>            enable_condition_str = " AND ".join(enable_condition)
>          else:
>
>
I was gonna commit the same thing but I see you beat me :)

-- 
Timofei Zhakov