Enjoy these well-formed patches.

2013/2/19 Alexander Sedov <[email protected]>

> Here it is, the new version.
>
>
> 2013/2/19 Christoph Lohmann <[email protected]>
>
>> Greetings.
>>
>> On Tue, 19 Feb 2013 15:54:06 +0100 Alexander Sedov <[email protected]>
>> wrote:
>> > This patch adds support for rectangular selections a-la urxvt, which
>> come
>> > in handy when using applications like irssi or mcabber.
>>
>> You are commenting out code and leave it there without any notice, if it
>> should be reused later. Next you are using a different style than the st
>> style, which means you use »if (« instead of »if(«. The same applies for
>> the switch case and the simple if clause, which should be
>>
>>         if() {
>>         } else {
>>         }
>>
>> If  that’s  fixed  your patch will be applied. The hard case why I’m not
>> applying it and notice you is because of commenting out the code. That’s
>> unclean.
>>
>>
>>
>> Sincerely,
>>
>> Christoph Lohmann
>>
>>
>>
>

Attachment: 0002-Rectangular-selection-support-added.patch
Description: Binary data

Attachment: 0007-Fixed-some-problems-with-rectsel-patch.patch
Description: Binary data

Attachment: 0009-Fixed-selection-redrawing-quirks.patch
Description: Binary data

Reply via email to