Roberto E. Vargas Caballero wrote:
> @@ -41,6 +41,7 @@ main(int argc, char *argv[])
> + char *err;
> @@ -58,15 +59,16 @@ main(int argc, char *argv[])
> + err = "error spawning child:%s";
Heyho Roberto,
why not immediately initialize the variable?
> - die("error executing shell:%s", strerror(errno));
> + err = "error executing shell:%s" ;
> case -1:
> - die("error spawning child:%s", strerror(errno));
> + die(err, strerror(errno));
Also I think this (unmarked!) fallthrough way harder to grasp at the first
glance. What benefit at all do we get from the patch?
--Markus
