On Mon, Apr 13, 2015 at 09:58:16PM +0200, Roberto E. Vargas Caballero wrote: > > > + case 'e': > > + /* xterm/rxvt compatibility */ > > + *argv[0] = '-'; > > + argc++, argv--; > > + break; > > case 'f': > > opt_font = EARGF(usage()); > > break; > > > Ha,ha, ha. Good hack, but it fails. Think in something like > st -e -sh.
It should be argv[0] = "--"; in fact. Current patch is completely broken, i sent a wrong version. > If the patch is only because you want to > remove the goto, then you are wrong. This goto is a perfect > example of a correct goto and it is even beatiful. I just wanted to make 'st mutt' work after i ran it and had to read man to find out that i should use -e. Also tried to reduce LOC count at the same time. > If you agree I will apply this version of your patch: Ok, just add a space between [-e command ...] and [command ...] here: > + " [-i] [-t title] [-w windowid] [-e command ...][command > ...]\n", And remove space between 'if' and ( here: > + if (argc > 1)
