On Tue, May 12, 2015 at 3:59 PM, FRIGN <d...@frign.de> wrote:
> On Tue, 12 May 2015 13:57:11 +0000
> Eivind Uggedal <eiv...@uggedal.com> wrote:
>
> Hey Eivind,
>
>> tarfd = 1;
>> + tarfd = 1;
>> - tarfd = 0;
>> + tarfd = 0;
>
> don't use explicit file-numbers. Use the names provided
> by the stdlib ("stdin", "stdout", "stderr") instead.
> And next time, please write some text to accomodate your
> patches, so people know what you changed.
> Additionally, this is common E-Mail etiquette, which I
> value highly.
>
I'd suggest STDIN_FILENO and STDOUT_FILENO?
cheers!
mar77i
