Hi,
Why do we need to get the number of cpus in runtime? It's a static
value, which in worst case changes after a reboot when disabling
hyperthreading.
Also, using ncpu for more than one thing (first it's flag, then it's a
number) is a really bad idea.
I don't think this should be merged, neither the whole 100% vs
per-core thing: I think that it gives little to no information, and it
doesn't seems to play nice with multi-threaded CPUs (in a 2:2 setup,
does having over 200% means that the cpu is over-the-top? Maybe it's
the same core, so it can handle more load, but maybe not, so, what
info did it gave to me?)
I totally agree to that. I will neither merge this patch, nor the 100%
thing. Thank you very much for your work, Kurt, but I think that these
two patches do not fit well into slstatus.
Regards,
Aaron
--
Web: https://drkhsh.at/ or http://drkhsh5rv6pnahas.onion/
Gopher: gopher://drkhsh.at or gopher://drkhsh5rv6pnahas.onion
GPG: 0x09e71697435bf54b
Fingerprint: 57D2 5F2C 9402 A6BD FEF9 B3B6 09E7 1697 435B F54B
